743 Dealing With Harsh Code Review Comments (Why Passive- Aggressive???) - Simple Programmer Podcast - a podcast by John Sonmez

from 2019-04-03T16:00

:: ::

Simple Programmer is now BACK with a brand new YouTube Channel
SUBSCRIBE HERE: https://simpleprogrammer.com/subscribespyt

If you work for some company writing code, you've probably dealt with code reviewers. These code reviewers aim to find flaws in your code, usually with the objective of improving and making the overall system works better.

However, this is not always what happens.

Sometimes, these code reviewers are complete idiots and they tell you nothing that matters. They don't make efforts to provide decent feedback and, end up being complete bastards. So, what should you do in these situations?

I recently got a question from a subscriber and he asked me the following question:

"I recently started with programming for Front-end development and working on my first project started 2 months back. A Code review was done last week and the feedback which i have got have 18 comments. For half of them I consider myself responsible as those comments are about formatting things and some redundant code, but latter half of them are just because of exiting logic which somebody else worked for same project and I have applied same to new functionality I am adding to the application.

And comments are slightly rude like strict commanding statements, expressing aggression about how long it took for him(code reviewer) to understand the code.

Could you help me how should I respond to this as this is first time for me and I really don't have any idea that would I be able to fix them all making sure code doesn't break down."

How should you handle passive-aggressive or even aggressive code review comments? Watch this video and find out.

Further episodes of Simple Programmer Podcast

Further podcasts by John Sonmez

Website of John Sonmez